Skip to content

STR-1184 & STR-1377: Bump reth to v1.3.1 and migrate to RSP #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 9, 2025
Merged

STR-1184 & STR-1377: Bump reth to v1.3.1 and migrate to RSP #825

merged 20 commits into from
Jun 9, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented May 23, 2025 •
edited
Loading

Description

  • Upgrade reth from v1.1.5 -> v1.3.1
  • Use RSP for AlpenEE proving
  • Refactor Strata -> Alpen for Evm components

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

  • This implementation currently burns the base fee instead of transferring it to the BASEFEE_ADDRESS.
    The issue is being tracked in STR-1442.
  • Uses a fork of rsp because the original library does not expose a public method to instantiate ClientExecutor. The changes in the fork are minimal. Need to reach out to the sp1 team or send a pull request to rsp.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@evgenyzdanovich evgenyzdanovich mentioned this pull request May 23, 2025
Closed
13 tasks
@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch 2 times, most recently from cf19a88 to cb5c559 Compare May 25, 2025 07:17
@evgenyzdanovich
Copy link
Contributor

mpt.rs has already been deleted (well, moved to a separate crate), mind potential conflicts around that...

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2025 •
edited
Loading

Commit: 9fb74bd

SP1 Execution Results

program cycles success
Bitcoin Blockspace 71,592 ✅
EVM EE STF 567,483 ✅
CL STF 167,046 ✅
Checkpoint 4,232 ✅

@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch 3 times, most recently from ed9f1d6 to 04daed4 Compare May 29, 2025 07:23
@MdTeach MdTeach changed the title STR-1184 Bump reth to v1.3.1 STR-1184 & STR-1377: Bump reth to v1.3.1 and migrate to RSP May 29, 2025
@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch 7 times, most recently from 4a23340 to 5774df0 Compare June 4, 2025 11:43
@storopoli
Copy link
Member

This is getting big! Close to 10k LoC diff.
Is this nearing to getting ready?

@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch 2 times, most recently from 043a5f7 to f225776 Compare June 5, 2025 03:20
@MdTeach MdTeach marked this pull request as ready for review June 5, 2025 03:22
@MdTeach MdTeach requested review from a team as code owners June 5, 2025 03:22
@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch 2 times, most recently from 92ad8cd to b30161d Compare June 5, 2025 05:17
@MdTeach
Copy link
Contributor Author

MdTeach commented Jun 6, 2025

PS: I think this needs to be backported to releases/0.2.0 once it's merged no? @MdTeach

This is not part of Testnet I.
So, I don't think we need to backport to releases/0.2.0

@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch from 32f8564 to afa24bf Compare June 6, 2025 08:15
storopoli
storopoli requested changes Jun 6, 2025
View reviewed changes
@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch 4 times, most recently from 66fcde2 to 8bdd2cf Compare June 6, 2025 10:28
@MdTeach MdTeach requested a review from storopoli June 6, 2025 10:29
storopoli
storopoli requested changes Jun 6, 2025
View reviewed changes
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I got the workspace issue with some crates not being members.
Final nit

@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch from 8bdd2cf to 43c672f Compare June 6, 2025 15:57
@MdTeach MdTeach requested a review from storopoli June 6, 2025 15:58
storopoli
storopoli previously approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 43c672f

@MdTeach MdTeach force-pushed the str-1184-bump-reth-v4 branch from 43c672f to 4451f3c Compare June 6, 2025 16:04
storopoli
storopoli approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4451f3c

@MdTeach MdTeach enabled auto-merge June 9, 2025 10:05
evgenyzdanovich
evgenyzdanovich reviewed Jun 9, 2025
View reviewed changes
evgenyzdanovich
evgenyzdanovich approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MdTeach MdTeach added this pull request to the merge queue Jun 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2025
@MdTeach MdTeach added this pull request to the merge queue Jun 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2025
@storopoli storopoli merged commit 8a69fd6 into main Jun 9, 2025
23 checks passed
@storopoli storopoli deleted the str-1184-bump-reth-v4 branch June 9, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storopoli storopoli storopoli approved these changes

@evgenyzdanovich evgenyzdanovich evgenyzdanovich approved these changes

@prajwolrg prajwolrg prajwolrg approved these changes

@delbonis delbonis delbonis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MdTeach @evgenyzdanovich @storopoli @bewakes @prajwolrg @delbonis