Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propoal: Set stop button color based on running tag. #492

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

vchigrin
Copy link
Contributor

@vchigrin vchigrin commented Jul 6, 2024

For me it appeared useful to make "stop" button take color of current activity tag, so I can quickly check whether I made
record after switching activity. May be it can be merged "as is", may be some settings should be added - I open for discussion on this topic.

Here is how it looks after these changes:

Screenshot 2024-07-06 at 22-10-08 TimeTagger - App

@almarklein
Copy link
Owner

Thanks! This seems like a nice touch, let's include it :)

Looks like you need to run black . in the root of the repo.

@vchigrin vchigrin force-pushed the colored-stop-button branch from e3dd3de to e2fe689 Compare July 14, 2024 21:12
@almarklein almarklein merged commit 332a51d into almarklein:main Jul 18, 2024
9 checks passed
truecharts-admin referenced this pull request in truecharts/public Jul 24, 2024
…v24.07.1@bfbc2d9 by renovate (#24202)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/almarklein/timetagger](https://togithub.com/almarklein/timetagger)
| minor | `v24.4.1-nonroot` -> `v24.07.1-nonroot` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>almarklein/timetagger (ghcr.io/almarklein/timetagger)</summary>

###
[`v24.07.1`](https://togithub.com/almarklein/timetagger/releases/tag/v24.07.1)

[Compare
Source](https://togithub.com/almarklein/timetagger/compare/v24.4.1...v24.07.1)

##### App

- Changed that the "now"-line was barely visible in darkmode by
[@&#8203;Tagirijus](https://togithub.com/Tagirijus) in
[https://github.com/almarklein/timetagger/pull/476](https://togithub.com/almarklein/timetagger/pull/476)
- Use standalone display for better user experience on Android. by
[@&#8203;vchigrin](https://togithub.com/vchigrin) in
[https://github.com/almarklein/timetagger/pull/491](https://togithub.com/almarklein/timetagger/pull/491)
- Fix recursion error due to early dates by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[https://github.com/almarklein/timetagger/pull/494](https://togithub.com/almarklein/timetagger/pull/494)
- Prevent negative timestamps, warn users when dates look odd by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[https://github.com/almarklein/timetagger/pull/495](https://togithub.com/almarklein/timetagger/pull/495)
- Make date visible on FireFix by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[https://github.com/almarklein/timetagger/pull/496](https://togithub.com/almarklein/timetagger/pull/496)
- Set stop button color based on running tag. by
[@&#8203;vchigrin](https://togithub.com/vchigrin) in
[https://github.com/almarklein/timetagger/pull/492](https://togithub.com/almarklein/timetagger/pull/492)
- Backspace can unselect all tags now by
[@&#8203;Tagirijus](https://togithub.com/Tagirijus) in
[https://github.com/almarklein/timetagger/pull/484](https://togithub.com/almarklein/timetagger/pull/484)
- Tweak unselecting with backspace by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[https://github.com/almarklein/timetagger/pull/497](https://togithub.com/almarklein/timetagger/pull/497)
- Support for multiple date formats by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[https://github.com/almarklein/timetagger/pull/498](https://togithub.com/almarklein/timetagger/pull/498)

##### Other

- Update test for new asgineer by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[https://github.com/almarklein/timetagger/pull/483](https://togithub.com/almarklein/timetagger/pull/483)

##### New Contributors

- [@&#8203;vchigrin](https://togithub.com/vchigrin) made their first
contribution in
[https://github.com/almarklein/timetagger/pull/491](https://togithub.com/almarklein/timetagger/pull/491)

**Full Changelog**:
almarklein/timetagger@v24.4.1...v24.07.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNiIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC42IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants