feat(eips): EIP-7594 sidecar #2273
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
force-pushed
the
rkrasiuk/eip7594
branch
from
ad05e66 to
bf1e853
Compare
mattsse
requested changes
Apr 2, 2025
rkrasiuk
force-pushed
the
rkrasiuk/eip7594
branch
from
bf1e853 to
53b9bef
Compare
rkrasiuk
commented
Apr 3, 2025
crates/eips/Cargo.toml
Outdated
| @@ -70,7 +70,7 @@ serde_json.workspace = true | |||
| rand.workspace = true | |||
|
|
|||
| [features] | |||
| default = ["std", "kzg-sidecar"] | |||
| default = ["std", "kzg-sidecar", "kzg"] | |||
rkrasiuk
force-pushed
the
rkrasiuk/eip7594
branch
8 times, most recently
from
3797c90 to
b93c92d
Compare
6 tasks
mattsse
requested changes
Apr 8, 2025
| @@ -88,8 +92,8 @@ impl From<TxEip4844> for TxEip4844Variant { | |||
| } | |||
| } | |||
|
|
|||
| impl From<(TxEip4844, BlobTransactionSidecar)> for TxEip4844Variant { | |||
| fn from((tx, sidecar): (TxEip4844, BlobTransactionSidecar)) -> Self { | |||
| impl From<(TxEip4844, BlobTransactionSidecarVariant)> for TxEip4844Variant { | |||
There was a problem hiding this comment.
this removes an impl, we should avoid this
Comment on lines
546
to
554
| pub fn validate_blob( | ||
| &self, | ||
| sidecar: &BlobTransactionSidecar, | ||
| sidecar: &BlobTransactionSidecarVariant, | ||
| proof_settings: &c_kzg::KzgSettings, | ||
| ) -> Result<(), BlobTransactionValidationError> { |
| @@ -776,13 +779,17 @@ pub struct TxEip4844WithSidecar { | |||
| pub tx: TxEip4844, | |||
| /// The sidecar. | |||
| #[cfg_attr(feature = "serde", serde(flatten))] | |||
| pub sidecar: BlobTransactionSidecar, | |||
| pub sidecar: BlobTransactionSidecarVariant, | |||
There was a problem hiding this comment.
with this approach we will always need runtime checks for the format, this would also be a significant breaking change that could trigger more breaking changes if the eip changes.
I'd prefer if we can make this a generic value instead then we can easily switch between
BlobTransactionSideCar, Variant, 7594 format
it' likely that we need a helper trait for validation then but this should be fine because we know all the variants
rkrasiuk
force-pushed
the
rkrasiuk/eip7594
branch
from
cd15ad4 to
f95441f
Compare
This was referenced May 12, 2025
rkrasiuk
force-pushed
the
rkrasiuk/eip7594
branch
from
f95441f to
9715113
Compare
rkrasiuk
force-pushed
the
rkrasiuk/eip7594
branch
from
9715113 to
d766aed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist