Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tried TxEnvelope fixes #2169

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

tried TxEnvelope fixes #2169

wants to merge 3 commits into from
+119 −70

Conversation

Rimeeeeee
Copy link

No description provided.

@Rimeeeeee
Copy link
Author

Rimeeeeee commented Mar 8, 2025 •
edited
Loading

i have tried to address the changes in TxEnvelope->EthereumTxEnvelope<Eip4844> but there are certain errors regarding Signed<Eip4844> ( declared inside enum) .Can you help me to fix those? @klkvr @mattsse

mattsse
mattsse requested changes Mar 8, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

smol nit

@Rimeeeeee
Copy link
Author

Rimeeeeee commented Mar 8, 2025 •
edited
Loading

ty

smol nit

i have done that..but there are some issues when dealing with Signed<Eip4844> in serde and impls...kindly look into it. @mattsse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse requested changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Alloy
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rimeeeeee @mattsse