Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use OnceBox #2165

Merged
merged 6 commits into from
Mar 7, 2025
Merged

fix: use OnceBox #2165

merged 6 commits into from
Mar 7, 2025
+45 −17

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Mar 7, 2025

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse mentioned this pull request Mar 7, 2025
Merged
@klkvr klkvr changed the title use OnceBox fix: use OnceBox Mar 7, 2025
@klkvr klkvr marked this pull request as ready for review March 7, 2025 17:57
@klkvr
Copy link
Member Author

klkvr commented Mar 7, 2025

OnceBox seems to work although slightly slower than std which is likely fine because we're always doing hashing before inserting

@mattsse mattsse merged commit 712798e into main Mar 7, 2025
27 checks passed
@mattsse mattsse deleted the klkvr/once-box branch March 7, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Alloy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse