refactor: delete Caller trait
#1893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
|
merge commit on #1892 makes it easier to start this from scratch now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1892
Motivation
Callertrait is unused, and results in extra indirection via structs likeArc<Weak<Client>>. Its abstraction over"eth_call"vs other methods is well-covered by custom ext traits on provider, or by custom transports if low-level rewriting is needed, so it seems safe to delete it.Solution
Remove the caller trait
This is a breaking change, as the
Calleris part of the public API. it is unused in alloy, in op-alloy, and in every other user i've checkedPR Checklist