chore: shift std::error impls to core #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
gakonst,
onbjerg and
klkvr
as code owners
DaniPopes
approved these changes
Jan 4, 2025
crates/eips/src/eip1898.rs
Outdated
| Self::FromHexError(err) => std::error::Error::source(err), | ||
| Self::ParseError(err) => std::error::Error::source(err), | ||
| Self::ParseIntError(err) => core::error::Error::source(err), | ||
| Self::FromHexError(err) => core::error::Error::source(err), |
There was a problem hiding this comment.
these are wrong btw, the source is err itself, not the source of the source
mattsse
force-pushed
the
matt/more-core-error-impls
branch
from
98dbafb to
8fcd91a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more core error impls
all of those could now use thiserror but I'd like to open a good first issue for this instead