Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Safetyhook mess into a mirror repo #2163

Merged
merged 7 commits into from
Jun 8, 2024
Merged

Conversation

Headline
Copy link
Member

@Headline Headline commented May 21, 2024

This patch reimplements all of the modifications made to safetyhook to make it compatible with SourceMod, but does so in the actual source/inc files so we can possibly take upstream changes in the future and make the amalgamation scripts a part of our build process.

I didn't attempt to call the amalgamation scripts in our builds yet - they're hard-pathed still (see alliedmodders/safetyhook@0c3a4c0), but this gets us most of the way there.

Someone should test that this stuff still works before we take it in

EDIT: I haven't compiled this for linux, either, so builds may fail with safetyhook errors

@Headline
Copy link
Member Author

Assuming those linux builders pass we can take this in if it tests ok with the TODO of:

  1. Generate the amalgam stuff with ambuild
  2. build this into a lib and link instead of including this in everything

@GAMMACASE
Copy link
Member

Providing some input on testing this fork, works great rn for me on x64 platforms on windows and linux.

@rowedahelicon
Copy link

Tested this on Debian 12, server boots up fine and a detour I use for testing worked out without problems.

@psychonic psychonic merged commit d42a8c7 into master Jun 8, 2024
4 checks passed
@psychonic psychonic deleted the safetyhook-mirror branch June 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants