docs: url fix #256
Merged
docs: url fix #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo in step 3 and revised step 5 closes #159
sinchang
reviewed
Apr 15, 2019
| @@ -64,7 +64,7 @@ All Contributors uses Docusaurus to maintain our documentation website. For more | |||
| To get started locally: | |||
| - `yarn install` | |||
| - `yarn start` | |||
| - go to http://localhost:3000 (Refresh the page for your changes to be reflected) | |||
| - go to `http://localhost:3000` (Refresh the page for your changes to be reflected) | |||
There was a problem hiding this comment.
prefer to change to markdown link
There was a problem hiding this comment.
@sinchang The problem with that is the fact that it will be treated as a live URL which would inevitably return noise on brokenlinkcheck which is what I tried to avoid doing this.
There was a problem hiding this comment.
@sinchang Do you have a better idea regarding that?
jakebolam
approved these changes
May 4, 2019
|
🎉 This PR is included in version 2.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Code comment the localhost URL and fix some minor typos.
Why:
Because the URL is treated as a live one ending up in yet another entry in the broken URLs (re #187) and some typos which got flagged by something.
How:
...
Checklist:
Bot Usage