Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404s on website #187

Open
jakebolam opened this issue Feb 12, 2019 · 18 comments
Open

Fix 404s on website #187

jakebolam opened this issue Feb 12, 2019 · 18 comments
Labels
bug Something isn't working pinned priority: medium status: available Available for grab

Comments

@jakebolam
Copy link
Collaborator

jakebolam commented Feb 12, 2019

There are a number of 404s being reported: https://www.brokenlinkcheck.com/broken-links.php

It would be good to resolve these, to avoid a bad browsing experience

@jakebolam jakebolam added the bug Something isn't working label Feb 12, 2019
@Berkmann18 Berkmann18 added the status: available Available for grab label Feb 12, 2019
@Berkmann18
Copy link
Member

Berkmann18 commented Feb 12, 2019

Here's the list of pages to fix:

It seems that the /project/contribute has the "http://localhost:3000" which is treated as an actual URL.

@jakebolam
Copy link
Collaborator Author

Looking alot better now!
screen shot 2019-02-23 at 8 53 51 pm

@prasadgujar
Copy link

prasadgujar commented Mar 10, 2019

@Berkmann18 @jakebolam can I work on an above-mentioned issue?

@Berkmann18
Copy link
Member

@prasadgujar Sure.

@jakebolam
Copy link
Collaborator Author

@prasadgujar let us know if you need anything

@prasadgujar
Copy link

@jakebolam
Sure.
Will start working on this asap.

@Berkmann18
Copy link
Member

Update on the broken URLs:
image

@Berkmann18 Berkmann18 mentioned this issue Apr 15, 2019
3 tasks
@theNaut1lus
Copy link

@Berkmann18 @jakebolam Would love to work on this as my first issue here, please give me the go ahead and some tips to start with

@Berkmann18
Copy link
Member

@co16353sidak Have a look at what allcontributors.org gives on https://www.brokenlinkcheck.com/broken-links.php and have a look at the files in this repo to fix what you can.
For the translations, you'll need to join https://crowdin.com/project/all-contributors.

@Berkmann18
Copy link
Member

Update (as of typing this):
image

@co16353sidak Have you had a chance to look at any of the issues, broken links etc?

@Hardik500
Copy link

Is the issue fixed?
If not can I work on it?

@Berkmann18
Copy link
Member

@Hardik500

Is the issue fixed?

The issue is not fully fixed. IIRC ~6 of the above 37 URLs should have been fixed by now.

If not can I work on it?

Of course.

@Berkmann18
Copy link
Member

Berkmann18 commented Mar 23, 2021

Update (as of 19th of April):

Edit: some of the above have been fixed, I'll see when the site gets rebuilt, what links are left.
Edit 2: Here's a script that looks at brokenlinkcheck to make the list above:

texts = [...document.querySelectorAll('#url_td_field_base')];[...document.querySelectorAll('#url_td_field')].map((url, i) => `- [ ] ${url.value} "${texts[i].value}"`).join('\n')

@H4M5TER
Copy link

H4M5TER commented Apr 1, 2021

@Berkmann18
I have noticed the link problems and failed to fix it today.
For example:
The original English string (on the github) is [The all contributors specification](specification).
The Chinese l10n string is (perhaps) [All contributors规范](规范).
And the correct form is [All contributors规范](specification)
I can only edit the display string (not the link address) on Crowdin.
And I can't download & edit & upload the translation in the file view.
Anyone would help?

@Berkmann18
Copy link
Member

@H4M5TER Thanks for pointing those out, I fixed all (or most I believe) the ids that were translated, feel free to double check.

@mathieucaroff
Copy link

Hi there, on the front page, the Docs link to https://allcontributors.org/docs redirects to https://allcontributors.org/docs/fr/overview which is a 404 😦

@Berkmann18
Copy link
Member

@mathieucaroff Yeah, someone mentioned it in the call for translators issue and it seems fine when looking at the project on CrowdIn; not sure why it's happening.

@Stream5710
Copy link

Hi there, on the front page, the Docs link to allcontributors.org/docs redirects to allcontributors.org/docs/fr/overview which is a 404 😦

Same for Japanese which redirects to https://allcontributors.org/docs/ja/overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned priority: medium status: available Available for grab
Projects
None yet
Development

No branches or pull requests

9 participants