Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the Explorer easier to use #702

Draft
wants to merge 51 commits into
base: beta
Choose a base branch
from

Conversation

alixlahuec
Copy link
Owner

@alixlahuec alixlahuec commented Jul 29, 2024

Description

Refactor the Explorer UI to make it easier to use and more intuitive:

  • queries are entered as a single string of text, rather than using multiple buttons & dropdowns
  • suggestions are shown during typing to show what filters are available & the values they take, and to speed up insertion

This unblocks rendering the Notes tab and having a functional PDFs tab, since both were unfinished pending the revamp.

TODO:

  • Reach functional parity with previous iteration (filters)
  • Solve the search trigger problem
  • Finish components styling
  • Add stories
  • Expand filters for PDFs and Notes

Validation

XXX

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 92.96875% with 18 lines in your changes missing coverage. Please review.

Project coverage is 84.07%. Comparing base (e8b185a) to head (16f3819).

Files Patch % Lines
...omponents/Dashboard/Explorer/QueryItems/filters.ts 87.18% 5 Missing ⚠️
...components/Dashboard/Explorer/QueryPDFs/filters.ts 16.67% 5 Missing ⚠️
...omponents/Dashboard/Explorer/QueryNotes/filters.ts 20.00% 4 Missing ⚠️
...c/components/Dashboard/Explorer/QueryBar/index.tsx 97.92% 1 Missing ⚠️
.../components/Dashboard/Explorer/QueryPDFs/index.tsx 75.00% 1 Missing ⚠️
src/components/Dashboard/Explorer/helpers.ts 97.30% 1 Missing ⚠️
src/hooks/useSearchQuery/helpers.ts 98.58% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #702      +/-   ##
==========================================
+ Coverage   83.53%   84.07%   +0.54%     
==========================================
  Files         159      159              
  Lines        4918     4846      -72     
  Branches     1407     1353      -54     
==========================================
- Hits         4108     4074      -34     
+ Misses        785      750      -35     
+ Partials       25       22       -3     
Files Coverage Δ
mocks/zotero/notes.ts 100.00% <ø> (ø)
...components/Dashboard/Explorer/QueryItems/index.tsx 100.00% <100.00%> (+5.89%) ⬆️
...components/Dashboard/Explorer/QueryNotes/index.tsx 100.00% <100.00%> (+100.00%) ⬆️
src/components/Dashboard/Explorer/index.tsx 96.30% <ø> (ø)
src/hooks/useSearchQuery/index.ts 100.00% <100.00%> (ø)
...c/components/Dashboard/Explorer/QueryBar/index.tsx 97.92% <97.92%> (ø)
.../components/Dashboard/Explorer/QueryPDFs/index.tsx 70.84% <75.00%> (-0.13%) ⬇️
src/components/Dashboard/Explorer/helpers.ts 97.30% <97.30%> (ø)
src/hooks/useSearchQuery/helpers.ts 98.58% <98.58%> (ø)
...omponents/Dashboard/Explorer/QueryNotes/filters.ts 20.00% <20.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

Copy link

socket-security bot commented Aug 3, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None +1 2.02 MB wanasit

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant