Rewrite strategy documentation to improve correctness #254
+216
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisaifee
force-pushed
the
strategy-doc-revision
branch
2 times, most recently
from
ea8a352 to
59f87a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 25 25
Lines 1586 1586
Branches 144 144
=======================================
Hits 1480 1480
Misses 76 76
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove ambiguity around window start/end for fixed windows - Add consistent scenarios for all strategies
alisaifee
force-pushed
the
strategy-doc-revision
branch
from
59f87a4 to
5573d65
Compare
|
@mje-nz if you'd like to take a quick look. |
|
cc @Merinorus just FYI since I made some tweaks to the sliding window strategy docs as well. |
Closed
|
I'll merge this for now since it should certainly be more accurate than before. If you have any suggestions for improvements please do let me know. |
|
That's more clear, with a practical example. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #250
Read the docs: https://limits.readthedocs.io/en/strategy-doc-revision/strategies.html