[ui] Fix: Improve UX for search by allowing Search focus to be removed when clicking outside box #2666
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent item when clicking
…ent item when clicking
…t item when clicking
…focus to the parent item when clicking
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2666 +/- ##
===========================================
- Coverage 69.96% 69.42% -0.54%
===========================================
Files 121 123 +2
Lines 7084 7167 +83
===========================================
+ Hits 4956 4976 +20
- Misses 2128 2191 +63 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where Search Text box focus was not getting stolen when clicking on few components in the Active UI.
Features list
Implementation remarks
Added MouseArea(s) to components allowing clicks to force focus on the parent components thereby stealing focus from anything that may have it, including the Search Input Text.