Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D-3D Point Cloud Registration based on PCL #1441

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

3D-3D Point Cloud Registration based on PCL #1441

wants to merge 36 commits into from

Conversation

servantftechnicolor
Copy link
Contributor

upgrade to #425

@fabiencastan fabiencastan changed the title Upgrade to 3D3D registration 3D-3D Point Cloud Registration based on PCL Jun 5, 2023
@servantftechnicolor servantftechnicolor force-pushed the dev/3D3Dregistration branch 3 times, most recently from 73ebfb6 to 83d5559 Compare June 6, 2023 12:29
@fabiencastan fabiencastan added this to the 3.2.0 milestone Jun 7, 2023
@natowi natowi mentioned this pull request Jun 7, 2023
Closed
Debize and others added 23 commits June 8, 2023 10:33
@Debize @servantftechnicolor
[registration] rough import of the 3D3D registration code into AV (co…
35ff68c 
…mpile)
@Debize @servantftechnicolor
[registration] rough changes in CmakeList files to make it runnable
8c2b428
@Debize @servantftechnicolor
[registration] input arguments refactoring (alicevision type)
95d5800
@Debize @servantftechnicolor
[registration] refactoring of verbose (alicevision type)
468bc4b
@Debize @servantftechnicolor
[registration] implement the 'transformAndSaveCloud()' to export tran…
59ef216 
…sformed cloud
@Debize @servantftechnicolor
[registration] add the 'showPipeline' option + renaming
1e6b10f
@TwokBox @servantftechnicolor
[registration] bugfix: solve conflict between scale ratio & measurements
00d03fc
@TwokBox @servantftechnicolor
[registration] manage .OBJ files
930a55d
@TwokBox @servantftechnicolor
[registration] add an option to show the duration of each step
a7cdf51
@TwokBox @servantftechnicolor
[registration] moveToOrigin uses centroid instead of center of boundi…
fc972d5 
…ng box
@TwokBox @servantftechnicolor
[registration] transformAndSaveCloud manages .obj files
da280a6
@TwokBox @servantftechnicolor
[registration] bugfix: fix error with scaleRatio & measurements manag…
505b214 
…ment
@yann-lty @servantftechnicolor
[3dregistration] fix CMakeLists + build
4a623f5
@fabiencastan @servantftechnicolor
[registration] fix crash on windows in moveToOrigin
bd4d2ed
@fabiencastan @servantftechnicolor
[registration] add ICP and SICP based on sparceicp implementation
cc1af4b 
* add scale support in point_to_point with directSimilarityEstimator
* add multiple modes to command line
* remove code using PCL windows: no UI inside the library
@fabiencastan @servantftechnicolor
[registration] make point cloud preparation common to all methods
ad05a3b 
Point cloud preparation means: center to origin, initial rescale and voxelgrid subsampling.
@fabiencastan @servantftechnicolor
[registration] registration preparation: disable voxel simplification…
802c2dd 
… if voxelSize is 0
@fabiencastan @servantftechnicolor
[registration] minor code clean for scaleRatio
60869cc
@fabiencastan @servantftechnicolor
[registration] some code fixes
a3c3980
@fabiencastan @servantftechnicolor
[cmake] some find_package changes for flann and pcl
3517347
@fabiencastan @servantftechnicolor
[registration] pcl now uses std::shared_ptr
02354b8
@fabiencastan @servantftechnicolor
[cmake] rename internal flann target
f191064
@simogasp @servantftechnicolor
[cmake] use alicevision_add_library
6df0232
@simogasp
Copy link
Member

simogasp commented Jun 8, 2023

maybe we can consider this opencv version of ICP
https://docs.opencv.org/4.7.0/dc/d9b/classcv_1_1ppf__match__3d_1_1ICP.html
It would avoid adding another (big) dependency like PCL

@fabiencastan fabiencastan modified the milestones: 3.2.0, 3.3.0 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@servantftechnicolor @simogasp @fabiencastan @Debize @TwokBox @yann-lty