Extract some code out of pipeline executables to reusable modules (part 2) #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
force-pushed
the
pipeline-reuse
branch
2 times, most recently
from
83da1d2
to
28e870e
Compare
p12tic
force-pushed
the
pipeline-reuse
branch
from
28e870e
to
28e705b
Compare
viewHasDefinedIntrinsic() accesses intrinsics from SfMData without synchronization, which races with intrinsics updates in the following line below. sfmData.getIntrinsics().emplace(intrinsicId, intrinsicBase);
This commit also fixes a couple of race conditions because access to unsureSensors and intrinsicsSetFromFocal35mm was not protected.
p12tic
force-pushed
the
pipeline-reuse
branch
from
28e705b
to
111b66e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves code out of cameraInit executable to aliceVision libraries that can be linked into other executables which in turn allows code reuse.
The
Extract ...commits only move code around reindenting it to 4-space indents in the process.The last commit changes how warning reporting is done in cameraInit. This can be potentially be reused in external code now too.
In this PR 3 race conditions have been identified and fixed.
This PR is a followup to #1270 and is filled separately because it solves a more complicated case.