Commits on Apr 9, 2024

1. Add Makefile help comments …

   Commit [1] that originally introduced make help target also had special
   comments (starting with ###) for help target to parse.
   Makefile that was finally merged after some changes lacked this
   comments. Without this comments when executed help prints empty output.
   
   PR: alicebob#371
   [1]: alicebob@72133e9
   
   Signed-off-by: Wojciech Szarański <[email protected]>

   

   wszaranski committed Apr 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 8fe7b38
   • Browse repository at this point

   Copy the full SHA

   8fe7b38 View commit details

   Browse the repository at this point in the history

2. Move .PHONY next to each target …

   It's clearer to keep target and it's .PHONY together. When reading
   Makefile it's easier to see if target is phony or not (without jumping
   back to first line and reading all of .PHONY dependencies). It's also
   harder to forget remove/rename .PHONY dependency when target is changed
   when they are together.
   
   There is no official standard but make documentation[1] in .DEFAULT_GOAL
   use multiple .PHONY:
   > .PHONY: foo
   > foo: ; @echo $@
   >
   > $(warning default goal is $(.DEFAULT_GOAL))
   >
   > # Reset the default goal.
   > .DEFAULT_GOAL :=
   >
   > .PHONY: bar
   > bar: ; @echo $@
   
   PR: alicebob#371
   [1]: https://www.gnu.org/software/make/manual/html_node/Special-Variables.html
   
   Signed-off-by: Wojciech Szarański <[email protected]>

   

   wszaranski committed Apr 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 5eca1e3
   • Browse repository at this point

   Copy the full SHA

   5eca1e3 View commit details

   Browse the repository at this point in the history