Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12135] upgrade module naocs-console from junit4 to junit5 #12136

Merged
merged 1 commit into from
May 29, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented May 24, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #12135

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (6bee5c4) to head (ed0748e).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12136      +/-   ##
=============================================
- Coverage      68.77%   68.72%   -0.05%     
- Complexity      9127     9129       +2     
=============================================
  Files           1252     1252              
  Lines          40886    40907      +21     
  Branches        4340     4340              
=============================================
- Hits           28119    28113       -6     
- Misses         10757    10781      +24     
- Partials        2010     2013       +3     

see 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bee5c4...ed0748e. Read the comment docs.

@KomachiSion KomachiSion added this to the 2.4.0 milestone May 29, 2024
@KomachiSion KomachiSion merged commit bc039bc into alibaba:develop May 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] module console upgrade to junit5
3 participants