Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue #12081] module api upgrade junit4 to junit5 #12082

Merged
merged 2 commits into from May 20, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented May 10, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #12081

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.


private static ObjectMapper mapper;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont change the indent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@shalk shalk requested a review from KomachiSion May 16, 2024 02:21
KomachiSion
KomachiSion previously approved these changes May 16, 2024
@KomachiSion
Copy link
Collaborator

There is one class conflict, simple fix it will be ready to merged.

@shalk
Copy link
Contributor Author

shalk commented May 16, 2024

It is strange for IT test fail only for JDK8 latest. But JDK8.0.192 is pass.
It maybe effect by 5169f06

@KomachiSion
Copy link
Collaborator

It is strange for IT test fail only for JDK8 latest. But JDK8.0.192 is pass. It maybe effect by 5169f06

TLS is depend os and jdk version. If jdk has some change for tls support or has some bug in jdk. It might effect test and runtime.

@KomachiSion KomachiSion merged commit 366c88e into alibaba:develop May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] module api upgrade to junit5
2 participants