feat: filter & rename processor support v2 model #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
snakorse
commented
Nov 13, 2023
snakorse
commented
- filter processor support v2 model:
- for log event, filter tags and content keys
- for other event, filter tags
- rename processor support v2 model:
- for log event, add support for rename tags
yyuuttaaoo
requested changes
Nov 13, 2023
| contents.Add(newKey, contents.Get(oldKey)) | ||
| contents.Delete(oldKey) | ||
| } else if p.NoKeyError { | ||
| case tags.Contains(oldKey): |
There was a problem hiding this comment.
不合理，不要把字段和tag混在一起处理，应该单独做一个TagRename
| tags := event.GetTags().Iterator() | ||
| contents := event.Contents.Iterator() | ||
| for key, reg := range p.includeRegex { | ||
| if v, ok := tags[key]; ok && reg.MatchString(v) { |
There was a problem hiding this comment.
不要处理tags，log的tag没有良好定义，并且和group的tag太容易混乱
| nextIdx := 0 | ||
| for idx := 0; idx < totalLen; idx++ { | ||
| if p.isEventMatch(in.Events[idx]) { | ||
| if idx != nextIdx { |
There was a problem hiding this comment.
这么写看起来是复杂了，性能如果没有实际测试过会更好的话，就画蛇添足了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.