Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bazel compile failed #34

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix bazel compile failed #34

merged 1 commit into from
Jun 5, 2024
+15 −11

Conversation

zyfjeff
Copy link
Collaborator

@zyfjeff zyfjeff commented Jun 4, 2024 •
edited by Lynskylate
Loading

fix #35

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zyfjeff zyfjeff requested a review from Lynskylate June 4, 2024 09:35
@Lynskylate
Copy link
Collaborator

Lynskylate commented Jun 4, 2024 •
edited
Loading

I create a another #35 issue.

We could fix the compile issue firstly, and then fix the coverage error.

@Lynskylate Lynskylate changed the title fix bazel coverage failed fix bazel compile failed Jun 5, 2024
@Lynskylate Lynskylate merged commit e528f1b into main Jun 5, 2024
1 of 3 checks passed
@Lynskylate Lynskylate deleted the fix-coverage branch June 5, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lynskylate Lynskylate Lynskylate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the CI compilation errors after switching to bazel modules.
3 participants
@zyfjeff @CLAassistant @Lynskylate