Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add special support to the four bytes utf-8 char #26

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

wbpcode
Copy link
Collaborator

@wbpcode wbpcode commented Jul 26, 2023

  • unit test
  • build option to disable this feature

To close #23

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 95.01% and project coverage change: +0.61% 🎉

Comparison is base (062ae70) 86.42% compared to head (706bf4e) 87.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   86.42%   87.03%   +0.61%     
==========================================
  Files          25       25              
  Lines        2195     2407     +212     
==========================================
+ Hits         1897     2095     +198     
- Misses        298      312      +14     
Files Changed Coverage Δ
hessian2/basic_codec/string_codec.cc 94.58% <95.01%> (-1.19%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wangbaiping added 2 commits July 28, 2023 18:12
Signed-off-by: wangbaiping <[email protected]>
@wbpcode wbpcode changed the title WIP: add special support to the four bytes utf-8 char add special support to the four bytes utf-8 char Jul 29, 2023
@zyfjeff zyfjeff merged commit b6dedde into alibaba:main Jul 31, 2023
1 check passed
@wbpcode wbpcode deleted the dev-utf-16-support branch July 31, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

string encoding/decoding is imcompatible with dubbo-hessian-lite for four char > 0xFFFF
3 participants