Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): fix bug in degree fusion in Insight Runtime #4529

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BingqingLyu
Copy link
Collaborator

Committed-by: BingqingLyu from Dev container

What do these changes do?

As titled.

Related issue number

Fixes #4528

Committed-by: BingqingLyu from Dev container
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Please check the preview of the documentation changes at
https://32b19123.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.02%. Comparing base (b0b8099) to head (129248b).
Report is 9 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0b8099) and HEAD (129248b). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (b0b8099) HEAD (129248b)
5 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4529       +/-   ##
===========================================
- Coverage   63.29%   33.02%   -30.27%     
===========================================
  Files         127      127               
  Lines       13319    13299       -20     
===========================================
- Hits         8430     4392     -4038     
- Misses       4889     8907     +4018     

see 80 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b8099...129248b. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Committed-by: BingqingLyu from Dev container
@BingqingLyu BingqingLyu marked this pull request as draft February 27, 2025 02:24
@BingqingLyu BingqingLyu force-pushed the fix_degree_fusion branch 2 times, most recently from 6f32098 to fc33ae9 Compare March 3, 2025 04:06
Committed-by: bingqing.lbq from Dev container
@BingqingLyu
Copy link
Collaborator Author

The bug occurs when using the ir-core based compiler. Skip these ir-core based tests as ir-core will be removed soon. Maybe it is better to set the default configuration in compiler as calcite-based? @shirly121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Degree Fusion occurs bug in Insight Runtime
2 participants