Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Overlay): ts & docs & test tools #4805

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

eamonzym
Copy link
Collaborator

close #4597

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是您为 Fusion/Next 提的第一个 pr,感谢您为 Fusion 做出的贡献,我们会尽快进行处理。

components/overlay/__docs__/demo/baisc/index.tsx Outdated Show resolved Hide resolved
components/overlay/__docs__/demo/controlled/index.tsx Outdated Show resolved Hide resolved
components/overlay/__docs__/demo/controlled/index.tsx Outdated Show resolved Hide resolved
components/overlay/__docs__/demo/controlled/index.tsx Outdated Show resolved Hide resolved
components/overlay/__docs__/demo/controlled/index.tsx Outdated Show resolved Hide resolved
components/overlay/types.ts Outdated Show resolved Hide resolved
components/overlay/types.ts Outdated Show resolved Hide resolved
components/overlay/types.ts Outdated Show resolved Hide resolved
components/overlay/utils/position.ts Outdated Show resolved Hide resolved
components/overlay/utils/position.ts Outdated Show resolved Hide resolved
components/overlay/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/overlay/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/overlay/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/overlay/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/overlay/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/overlay/types.ts Outdated Show resolved Hide resolved
components/overlay/types.ts Outdated Show resolved Hide resolved
components/overlay/types.ts Show resolved Hide resolved
components/overlay/types.ts Outdated Show resolved Hide resolved
tools/checkers/eslint.ts Outdated Show resolved Hide resolved
components/overlay/gateway.tsx Show resolved Hide resolved
components/overlay/index.tsx Show resolved Hide resolved
components/overlay/popup.tsx Show resolved Hide resolved
components/overlay/types.ts Show resolved Hide resolved
components/overlay/types.ts Show resolved Hide resolved
components/overlay/types.ts Show resolved Hide resolved
@eternalsky
Copy link
Contributor

ts 检查和 check 检查都没过,可以看一下原因,ts 检查应该其他 pr 引入的,可以 rebase 一下 master,注意是 rebase 不是直接 merge,目前 commit 里有很多的 merge commits,这个后续应该避免的。

components/overlay/popup-v2.tsx Show resolved Hide resolved
components/overlay/popup-v2.tsx Show resolved Hide resolved
components/overlay/popup.tsx Show resolved Hide resolved
components/overlay/popup.tsx Show resolved Hide resolved
components/overlay/popup.tsx Show resolved Hide resolved
components/overlay/utils/position.ts Show resolved Hide resolved
components/overlay/utils/position.ts Show resolved Hide resolved
components/overlay/utils/position.ts Show resolved Hide resolved
components/overlay/utils/position.ts Show resolved Hide resolved
components/overlay/utils/position.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【Technical upgrade】Overlay
2 participants