Open
Conversation
Contributor
Author
|
@safeforge @algodave Ciao. Please check when you can. Thanks. |
Member
|
Thank you @sinankeskin, your contribution is always much appreciated. I see the migration involves many files I haven’t had a chance to review. My only feedback for now is the missing test report, as the tests didn’t run for some reason. Since I’m no longer directly involved in ember development, having a test suite would be very helpful for the project. |
Contributor
Author
|
Test is there. I just separated. You just need to allow GitHub Actons to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts addon to v2 addon format.