Skip to content

Conversation

FabienMotte
Copy link
Contributor

Summary

This PR adds fallbacks for unhandled tools:

  • In development, it throws an error asking the user to provide a tool implementation using the tools prop.
  • In production, it adds a tool result with the output "No tool implemented for ...", which triggers a new request to the agent.

@FabienMotte FabienMotte requested a review from Haroenv October 17, 2025 08:09
@FabienMotte FabienMotte self-assigned this Oct 17, 2025
@FabienMotte FabienMotte force-pushed the feat/chat-unhandled-tools branch from 6f805b5 to b3fe1ce Compare October 17, 2025 08:09
Copy link

codesandbox-ci bot commented Oct 17, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 808d84b:

Sandbox Source
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some tests should be updated

@FabienMotte FabienMotte force-pushed the feat/chat-unhandled-tools branch from b3fe1ce to 51c985d Compare October 17, 2025 14:50
@FabienMotte FabienMotte force-pushed the feat/chat-unhandled-tools branch from 51c985d to b569c6d Compare October 17, 2025 14:51
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, I think we can just move the "null" branch from within tools to outside

@FabienMotte FabienMotte enabled auto-merge (squash) October 17, 2025 15:33
@FabienMotte FabienMotte merged commit 4210d55 into master Oct 17, 2025
14 checks passed
@FabienMotte FabienMotte deleted the feat/chat-unhandled-tools branch October 17, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants