Skip to content

Conversation

shaejaz
Copy link
Contributor

@shaejaz shaejaz commented Oct 15, 2025

Summary
This PR moves the chat widget tests to the CTS and adds additional CTS tests to cover most of the widgets API.

shaejaz and others added 8 commits October 9, 2025 16:29
we require to add a default for flavor that isn't actually used in all tests, but that's ok. If we migrate other ones later it will be consistent once the suite itself becomes generic
@shaejaz shaejaz changed the base branch from master to feat/common-chat-tests October 15, 2025 12:56
Copy link

codesandbox-ci bot commented Oct 15, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d05dd23:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@shaejaz shaejaz changed the title feat(chat): add and move tests to the CTS test(chat): add and move tests to the CTS Oct 15, 2025
Comment on lines 250 to 258
expect(
document.querySelector('.custom-title-icon')!.textContent
).toBe('Custom title icon');
expect(
document.querySelector('.custom-close-icon')!.textContent
).toBe('Custom close icon');
expect(
document.querySelector('.custom-maximize-icon')!.textContent
).toBe('Custom maximize icon');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the minimize icon component doesn't actually get used to render anything. If that is the case, we might want to remove/refactor/rename the max and/or min components.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaejaz shaejaz marked this pull request as ready for review October 16, 2025 10:49
Base automatically changed from feat/common-chat-tests to master October 16, 2025 12:03
@shaejaz shaejaz enabled auto-merge (squash) October 17, 2025 10:22
@shaejaz shaejaz merged commit 680c2f9 into master Oct 17, 2025
14 checks passed
@shaejaz shaejaz deleted the feat/chat-tests branch October 17, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants