-
Notifications
You must be signed in to change notification settings - Fork 553
test(chat): add and move tests to the CTS #6752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
we require to add a default for flavor that isn't actually used in all tests, but that's ok. If we migrate other ones later it will be consistent once the suite itself becomes generic
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d05dd23:
|
expect( | ||
document.querySelector('.custom-title-icon')!.textContent | ||
).toBe('Custom title icon'); | ||
expect( | ||
document.querySelector('.custom-close-icon')!.textContent | ||
).toBe('Custom close icon'); | ||
expect( | ||
document.querySelector('.custom-maximize-icon')!.textContent | ||
).toBe('Custom maximize icon'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the minimize icon component doesn't actually get used to render anything. If that is the case, we might want to remove/refactor/rename the max and/or min components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0c5c0ed
to
3a00e6c
Compare
Summary
This PR moves the chat widget tests to the CTS and adds additional CTS tests to cover most of the widgets API.