fix(instantsearch-ui-components): separate own props from component props in chat #6741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 04d3424:
|
shaejaz
reviewed
Oct 9, 2025
Haroenv
approved these changes
Oct 9, 2025
FabienMotte
force-pushed
the
fix/separate-own-component-props
branch
from
ac27211 to
4004b17
Compare
FabienMotte
changed the base branch from
master
to
feat/chat-custom-toggle-button
FabienMotte
force-pushed
the
feat/chat-custom-toggle-button
branch
from
e33d55a to
4c93206
Compare
FabienMotte
force-pushed
the
fix/separate-own-component-props
branch
from
4004b17 to
da122c6
Compare
Good idea, done! |
Haroenv
approved these changes
Oct 13, 2025
shaejaz
approved these changes
Oct 14, 2025
FabienMotte
force-pushed
the
feat/chat-custom-toggle-button
branch
2 times, most recently
from
e2e30ae to
74217dc
Compare
…rops in chat # Conflicts: # packages/instantsearch-ui-components/src/components/chat/Chat.tsx
FabienMotte
force-pushed
the
fix/separate-own-component-props
branch
from
265ed61 to
04d3424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR separates the chat header and prompt components prop types: own props and own props +
ComponentProps</* ... */>