fix(memory): cache key includes agent id #6737
Merged
+34
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
aymeric-giraudet and
shaejaz
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf770e4:
|
shaejaz
approved these changes
Oct 7, 2025
This ensures the same chat is restarted, only if the configuration matched. I think there may also be something possible with chat.id that gets generated after creation of the chat, but i don't think we can reason anything about its identity.
Haroenv
force-pushed
the
fix/no-restart-different-chat
branch
from
821a956 to
cf770e4
Compare
FabienMotte
added a commit
that referenced
this pull request
Oct 16, 2025
This reverts commit 58f86b6.
FabienMotte
added a commit
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ensures the same chat is restarted, only if the configuration matched.
I think there may also be something possible with chat.id that gets generated after creation of the chat, but i don't think we can reason anything about its identity.
Result
if you change the agentId, the chat is restarted.