feat(java): add bridge to transformation on search #4939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
millotp
reviewed
Jun 10, 2025
| ? clientOptions.getCustomRequester() | ||
| : defaultRequester(appId, apiKey, clientName, clientOptions, defaultHosts, connectTimeout, readTimeout, writeTimeout); | ||
| this.clientOptions = options != null ? options : new ClientOptions(); | ||
| this.executor = this.clientOptions.getExecutor(); |
There was a problem hiding this comment.
this is optional in java, I think you can omit most of them for readability
There was a problem hiding this comment.
ah I just copied the line below, this should work then 328348a
| @@ -158,7 +158,7 @@ export async function runCts( | |||
| assertValidReplaceAllObjectsFailed(languages.length - skip('dart')); | |||
| assertValidReplaceAllObjectsScopes(languages.length - skip('dart')); | |||
| assertValidWaitForApiKey(languages.length - skip('dart')); | |||
| assertPushMockValid(only('javascript') + only('go') + only('python')); | |||
| assertPushMockValid(only('javascript') + only('go') + only('python') + only('java')); | |||
| {{^autoCreateClient}}{{client}} client = {{/autoCreateClient}}new {{client}}("{{parametersWithDataTypeMap.appId.value}}","{{parametersWithDataTypeMap.apiKey.value}}"{{#hasRegionalHost}}{{#parametersWithDataTypeMap.region}},"{{parametersWithDataTypeMap.region.value}}"{{/parametersWithDataTypeMap.region}}{{/hasRegionalHost}}{{#useEchoRequester}},withEchoRequester(){{/useEchoRequester}}{{#hasCustomHosts}},withCustomHosts(Arrays.asList({{#customHosts}}new Host("true".equals(System.getenv("CI")) ? "localhost" : "host.docker.internal", EnumSet.of(CallType.READ, CallType.WRITE), "http", {{port}}){{^-last}},{{/-last}}{{/customHosts}}), {{gzipEncoding}}){{/hasCustomHosts}}); |
There was a problem hiding this comment.
this adds a new line everywhere, can you put the hasTransformationRegion at the end of the first line pls ?
There was a problem hiding this comment.
I thought that for the sake of the template readability it was better to have an empty line in tests, wdyt?
millotp
approved these changes
Jun 10, 2025
algolia-bot
added a commit
that referenced
this pull request
Jun 10, 2025
…) [skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jun 10, 2025
algolia/api-clients-automation#4939 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3792
Changes included:
follow up of #4852 and #4898 and #4924