feat(javascript): add exactOptionalPropertyTypes to tsconfig
#4935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
millotp
reviewed
Jun 6, 2025
| @@ -17,7 +17,7 @@ export function createIterablePromise<TResponse>({ | |||
| error, | |||
| timeout = (): number => 0, | |||
| }: CreateIterablePromise<TResponse>): Promise<TResponse> { | |||
| const retry = (previousResponse?: TResponse): Promise<TResponse> => { | |||
| const retry = (previousResponse?: TResponse | undefined): Promise<TResponse> => { | |||
There was a problem hiding this comment.
exactOptionalPropertyTypes is only for type or interface, you don't need to change the parameters in functions
There was a problem hiding this comment.
I prefer to stay consistent consider I don't really know what's the upstream impact of this, it added a bit more of work but at least there should be no surprise
millotp
approved these changes
Jun 6, 2025
|
gg for taking care of it |
i'm not a fan as well since it's just for the sake of explicitly typing things but if it makes things easier on the consumer side it seems like a good addition |
algolia-bot
added a commit
that referenced
this pull request
Jun 9, 2025
… (generated) [skip ci] Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jun 9, 2025
…ated) algolia/api-clients-automation#4935 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3873
Changes included:
closes algolia/algoliasearch-client-javascript#1587
for sake of explicit typing, we can enable this option as requested in algolia/algoliasearch-client-javascript#1587 to explicitely add
undefinedto optional properties.