https://github.com/alfio-event/alf.io/issues/1125 #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* enable accessibility for pdf ticket * add metadata for credit-note/invoice/receipt
alfio-event#1067) * initial work for removing log4j2 lombok annotation * continue removal log4j2 annotation work * continue removal log4j2 annotation work * continue removal log4j2,slf4j annotation work * remove utilityclass lombok annotation * fix some errors in the build * misc cleanup
* alfio-event#1068 remove sneakythrow * alfio-event#1068 initial work for removing AllArgsConstructor
* api key system components working * api-key-system bulk * apikey bulk file * Disable button if not valid form * Remove console.log
* Removed default message api key works from template * creat component event-item already takes the even from dashboad, img resposnsive * optimize image loading * UI event, load events, sort, active / past * Crate modal UI * Add logic for date * Validation date on export * Improved style for event title and pending payments logic * Remove not from ngif condition * Remove detail button
* Added docs for Mollie Added a simple guide how to configure Mollie for use in Alf.io as payment method. * Added section supported payment methods
* Fix button cancel from export modal * Added cards * Clean * Add ng2-charts library * Fixed cards using cols * Improve event detail view * Added panel with even info and language description * Logic pieChart * Added ticketStatistics call and model * Added lineChart logic and formated data user friendly * Added pipe and logics for cards event * Added a few menu voices * various fixes
* begining categories * translate api-key list, user system, organizations * translate event dashboard
* list menu with icons * Added pipes, progress bar and check box logic part 1 * logic progress bar * Fixed pipe for active and expire * translate * fixed button's esthetic * fixed icons from menu * fixed some classes * added empty component ticket category detail * fixed svg from button * various fixes pr * fixed typos
|
@syjer Please review. |
|
Hi @sergyer , thank you for the PR. Everything seems ok. Can I ask you to change the pull request so the target branch is Thank you :) |
|
@syjer Sure. Done. |
|
Hi @sergyer , I guess a cherry-pick of your commit on top of the 2.0-M4-maintenance would have been better, as currently this PR cannot be merged, as the branches have diverged too much. (You may have noticed the the impossibility to merge you PR due to the amount of changed files outside your change). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -41,7 +42,7 @@ | |||
|
|
|||
| public static void sendHeaders(HttpServletResponse response, String eventName, String reservationId, BillingDocument billingDocument) { | |||
| response.setHeader("Content-Disposition", "attachment; filename=\"" + getBillingDocumentFileName(eventName, reservationId, billingDocument) + "\""); | |||
| response.setContentType("application/pdf"); | |||
| response.setContentType(MediaType.APPLICATION_PDF_VALUE); | |||
Check warning
Code scanning / CodeQL
HTTP response splitting Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added voucher code in attendees data.