Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
To facilitate easy deployment to Heroku, and perform the changes needed to make that possible.
This PR resolves #1284.
Individual commits
composer test
running, and don't know why there were so many deletions in thepackage.json
file, but everything still works.composer
andnode
in 1 environment is not possible in Heroku, since they providebuildpacks
, specialised environment for building eithernode
orphp
environments.I've used the environment variable
CI
to distinguish between Heroku and another environment, since they commonly set that to indicate a CI environment. Not making this distinction would result in a failing build at Heroku because the binarycomposer
would not be present in anode
environment.