Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language support for AWS Locations service #1666

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

noma4i
Copy link
Contributor

@noma4i noma4i commented Nov 5, 2024

This change will use language option from the config. Example:
language: :en
Before this PR:

  label = "ทางหลวงชนบทภก. 4018 ตำบลเชิงทะเล อำเภอถลาง จังหวัดภูเก็ต 83110",
  municipality = "ตำบลเชิงทะเล",
  postal_code = "83110",
  region = "จังหวัดภูเก็ต",
  sub_region = "อำเภอถลาง",

after:

  label = "Phuket 4018 Rural Rd, Choeng Thale, Thalang, Phuket 83110, THA",
  municipality = "Choeng Thale",
  postal_code = "83110",
  region = "Phuket",
  sub_region = "Thalang",

@alexreisner
Copy link
Owner

This looks good, thanks. Just one nitpicky thing: could you move the new code 4 lines down, rather than breaking up the two statements that deal with Aws::ParamValidator?

@noma4i
Copy link
Contributor Author

noma4i commented Nov 6, 2024

@alexreisner done

@alexreisner alexreisner merged commit e4e2a88 into alexreisner:master Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants