Add IPInfoDB API #1324
Open
Add IPInfoDB API #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay on this. I'm a little hesitant to merge because IPInfoDB looks like a repackaging of IP2Location. So my question is: why would someone use IPInfoDB over IP2Location? (Reason for asking is that each new API adds a bit of time and effort to maintaining the gem so I'm limiting additions to APIs that offer access to new information, or a different pricing plan, or increased availability, etc.) |
|
This integration is for IPInfoDB which is free and different from IP2Location |
|
OK, however there are a bunch of test errors and failures. Could you please take a look at those? |
This reverts commit 0a1efe6.
|
Hi @alexreisner We are facing the branch conflicts issue. May we know how to solve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.