Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #659.
A command tagged
passthrough:"partial"currently stops flag parsing as soon as the command is selected, socommand --flag value programforwards--flag valueinstead of parsing the inherited flag. Apply partial passthrough to the command's single positional argument so inherited flags are parsed until the first positional; arguments after that point are forwarded unchanged. Empty/default and explicitallmodes retain their existing behavior.The regression cases cover inherited long/short/equals flags, flags on either side of the positional boundary, unknown flags,
--, a bare dash, empty input, and aliases. The README describes the command modes explicitly.Validation on Windows:
go test -count=1 ./...passes with Go 1.24.13 and Go 1.27.1.go vet -structtag=false ./...passes. Plaingo vet ./...reports the same existing shorthand struct-tag diagnostics on the unchanged base and this patch; the project's lint configuration already excludes those diagnostics.The complete hosted Linux/Windows matrix has not run locally.