Fix ExpandPath so it always returns a clean path and resolves "~" to the home directory - #658
Open
anuragkumar19 wants to merge 1 commit into
Open
anuragkumar19 wants to merge 1 commit into
anuragkumar19 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
ExpandPathdoes afilepath.IsAbscheck at the start, and if the path is absolute, it returns the path unmodified. This skips the cleaning normally performed byfilepath.Joinorfilepath.Abson other code paths. For example, the path/a/c/../cis returned unmodified.~doesn't resolve to the home directory; instead, it gets joined with the working dir byfilepath.Abs.Fixes
filepath.IsAbscheck. If the path is already absolute,filepath.Abswill clean and return it.~to the home directory.ExpandPath.Tests
go test ./...passes.