Support string fields in the filecontent mapper - #655
Closed
be-student wants to merge 1 commit into
Closed
be-student wants to merge 1 commit into
be-student wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482.
Allow
type:"filecontent"onstringfields, including named string types, using the same file/stdin reading path as[]byte. Preserve the file's bytes when converting to a string. Unsupported scalar and slice types still return validation errors; the existing panic fix from #625 remains covered with integer and string-slice controls.Validation: string file, default/named-string, and stdin regressions fail before the change. Full tests, race tests, repository-pinned
golangci-lint, gofmt, and diff checks pass.go vet -structtag=false ./...passes; plain vet flags the project's existing shorthand struct tags. Tested on Go 1.27.1/macOS; lint uses the repository's Hermit toolchain. README documents the supported field types.