Remove whitespace tokenizing rule in markdown lexer #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudchamb3r
changed the title
cloudchamb3r
changed the title
|
Apologies for the delay. It's not clear to me what this fixes, can you add some test data that proves it's fixing the underlying issue? |
|
Ok, I'll add it soon |
|
@alecthomas I updated my pull requests. please review again. thank you |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #744
related issue: go-gitea/gitea#32136
current markdown lexer is tokenizing by whitespace, but in markdown sytanx this implementation can cause some errors.