Pager friendly terminal formatting #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say a pager, like moar (uses Chroma for syntax highlighting) or
less, shows a line in the middle of a file.Unless that line starts with the correct formatting for the line, the pager would have to scan the whole file from the start to get the coloring of this single line right.
Before this PR, lines were not guaranteed to start with formatting, but could sometimes rely on formatting from the preceding lines.
With this change in place, lines can now stand by themselves, and paging will work better on Chroma's output.
Missing formatting at the start of the line would happen when a token had a linefeed in the middle.