Add CSV lexer #1005
Merged
Add CSV lexer #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be updated once we have a lexer in place.
I believe this test case contains all corner cases from the spec.
Both by fixing the indentation to make the test suite happy and by adding LiteralStringEscape to the expected output.
|
@alecthomas what's your opinion here? I'm aware there are non-RFC compliant CSV files out there, but mis-coloring those I think should be OK since their contents will still be intact. Or is there some other holdup for CSV coloring? |
alecthomas
approved these changes
Nov 10, 2024
|
Sorry, I missed this. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lexer for RFC-4180 compliant CSV files.
Fixes #1004.