-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix in conda.recipe #2214
Fix in conda.recipe #2214
Conversation
Reviewer's Guide by SourceryThis pull request updates the conda recipe and pre-commit hooks. It upgrades several dependencies to their latest versions, including No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add a PR description explaining the rationale behind the dependency changes, particularly moving pytorch to 'suggests' and adding albucore as a required dependency.
- The addition of albucore==0.0.22 as a strict requirement needs explanation. Why is this dependency needed and why is it pinned to this specific version?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
=========================================
+ Coverage 0 89.29% +89.29%
=========================================
Files 0 50 +50
Lines 0 8987 +8987
=========================================
+ Hits 0 8025 +8025
- Misses 0 962 +962 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Update dependencies versions.
Enhancements:
pydantic
version to 2.9.2.typing-extensions
to 4.9.0.opencv-python-headless
version to 4.9.0.80.albucore==0.0.22
to dependencies.scipy
version to 1.10.0.pyyaml
to dependencies.Build:
pyproject.toml
to addpytorch
andtext
optional dependencies.Tests:
types-PyYAML
andtypes-setuptools
toadditional_dependencies
.