Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in conda.recipe #2214

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Fix in conda.recipe #2214

merged 1 commit into from
Dec 21, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Dec 21, 2024

Summary by Sourcery

Update dependencies versions.

Enhancements:

  • Update minimum pydantic version to 2.9.2.
  • Update minimum typing-extensions to 4.9.0.
  • Update minimum opencv-python-headless version to 4.9.0.80.
  • Add albucore==0.0.22 to dependencies.
  • Update minimum scipy version to 1.10.0.
  • Add pyyaml to dependencies.

Build:

  • Update pyproject.toml to add pytorch and text optional dependencies.

Tests:

  • Update mypy version to 1.14.0 and add types-PyYAML and types-setuptools to additional_dependencies.

Copy link
Contributor

sourcery-ai bot commented Dec 21, 2024

Reviewer's Guide by Sourcery

This pull request updates the conda recipe and pre-commit hooks. It upgrades several dependencies to their latest versions, including numpy, scipy, pydantic, typing-extensions, and opencv-python-headless. It also adds several new dependencies, including pyyaml and albucore, and suggests pytorch, huggingface-hub, and pillow. Finally, it updates the mypy pre-commit hook to the latest version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Upgrade dependencies
  • Upgrade numpy to 1.24.4
  • Upgrade pydantic to 2.9.2
  • Upgrade typing-extensions to 4.9.0
  • Upgrade opencv-python-headless to 4.9.0.80
  • Add pyyaml
  • Add albucore 0.0.22
  • Add suggests for pytorch, huggingface-hub, and pillow
  • Upgrade scipy to 1.10.0
conda.recipe/meta.yaml
Update pre-commit hooks
  • Upgrade mypy to 1.14.0
  • Update mypy additional dependencies to include pydantic>=2.9
  • Add pytorch as optional dependency in pyproject.toml
.pre-commit-config.yaml
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add a PR description explaining the rationale behind the dependency changes, particularly moving pytorch to 'suggests' and adding albucore as a required dependency.
  • The addition of albucore==0.0.22 as a strict requirement needs explanation. Why is this dependency needed and why is it pinned to this specific version?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (b1a79c2) to head (230b6e4).
Report is 324 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2214       +/-   ##
=========================================
+ Coverage      0   89.29%   +89.29%     
=========================================
  Files         0       50       +50     
  Lines         0     8987     +8987     
=========================================
+ Hits          0     8025     +8025     
- Misses        0      962      +962     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 1e7384c into main Dec 21, 2024
16 checks passed
@ternaus ternaus deleted the fix_conda_build branch December 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant