Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kornia to benchmark #1582

Merged
merged 9 commits into from
Mar 19, 2024
Merged

Add kornia to benchmark #1582

merged 9 commits into from
Mar 19, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Mar 14, 2024

No description provided.

@ternaus ternaus marked this pull request as draft March 14, 2024 00:36
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

General suggestions:

  • Consider adding more detailed docstrings to the new utility classes and methods to improve code readability and maintainability.
  • Review the handling of edge cases in data processing, particularly in the conversion and comparison of benchmark results.
  • Ensure that the new benchmarking utilities are integrated seamlessly with existing benchmarking workflows.
Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ternaus ternaus marked this pull request as ready for review March 19, 2024 01:59
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It looks like we've already reviewed this pull request.

@ternaus ternaus merged commit db333d4 into main Mar 19, 2024
17 checks passed
@ternaus ternaus deleted the add_kornia_to_benchmark branch March 19, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant