Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor grid shuffle #1578

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Refactor grid shuffle #1578

merged 9 commits into from
Mar 12, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Mar 12, 2024

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

General suggestions:

  • Consider adding more detailed docstrings to newly introduced functions to improve code readability and maintainability.
  • Review the error handling and validation logic to ensure that edge cases are adequately covered, especially in functions that perform transformations based on input parameters.
  • Evaluate the efficiency of the new grid splitting and shuffling algorithms, particularly for large images or grids, to ensure that performance remains optimal.
Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

ternaus and others added 4 commits March 12, 2024 13:37
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@ternaus ternaus merged commit 0cb8de5 into main Mar 12, 2024
17 checks passed
@ternaus ternaus deleted the refactor_grid_shuffle branch March 12, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants