Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pad if needed serialization #1570

Merged
merged 6 commits into from
Mar 9, 2024
Merged

Fix pad if needed serialization #1570

merged 6 commits into from
Mar 9, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Mar 9, 2024

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

General suggestions:

  • Consider reviewing the consistency of error messages and fixing typographical errors for clarity.
  • Ensure that all new parameters introduced in augmentation classes are well-documented and tested.
  • Verify the backward compatibility of serialization changes with existing serialized objects.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

ternaus and others added 2 commits March 8, 2024 17:12
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@ternaus ternaus merged commit f744c83 into main Mar 9, 2024
17 checks passed
@ternaus ternaus deleted the fix_PadIfNeededSerialization branch March 9, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants