Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update used by #1556

Merged
merged 14 commits into from
Mar 2, 2024
Merged

Update used by #1556

merged 14 commits into from
Mar 2, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Mar 2, 2024

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces several enhancements across the project, focusing on improving documentation and automation within the CI pipeline. Specifically, it updates the 'Who is using Albumentations' section in the README, upgrades dependencies in the pre-commit configuration, and adds a new script for maintaining the README section. Additionally, it refines the documentation generation process and simplifies the interface in the domain adaptation functional module.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Consider implementing error handling and logging mechanisms in the new make_used_by_docs.py script to improve its robustness and user experience.
  • Review the simplification of method signatures in the domain_adaptation_functional.py file to ensure that the removal of explicit ellipses does not impact readability or documentation.
  • Ensure that the updates to the README and the addition of the new script are well-documented internally so that team members are aware of how to use these new tools effectively.
  • Given the updates to the pre-commit configuration and the addition of a new script, it might be beneficial to review and possibly update the project's contribution guidelines to reflect these changes.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ternaus ternaus merged commit 9b2863b into main Mar 2, 2024
17 checks passed
@ternaus ternaus deleted the update_used_by branch March 2, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant