Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eraser #1152

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Eraser #1152

wants to merge 16 commits into from

Conversation

Lemorra
Copy link

@Lemorra Lemorra commented Apr 10, 2022

Eraser is a sub-module to synthesis a new dataset that has equal numbered of instances of different classes from an existing dataset. It requires the associated label txts in kitti format.

@Lemorra
Copy link
Author

Lemorra commented May 19, 2022

@ternaus I hope its okay to tag you here. I'm tagging you here for a request to assign a reviewer to review my merge request.

@Dipet
Copy link
Collaborator

Dipet commented May 27, 2022

Hi. Sorry for the late response. Please, remove pre-commit changes, they are not needed for your changes and they made a lot of changes in files that are not related to your target changes.
Now it is hard to analyze your changes

@Dipet Dipet added wontfix This will not be worked on Improvements needed Something not implemented well. The maintainers requested improvements. labels Jun 11, 2022
@Lemorra
Copy link
Author

Lemorra commented Jul 19, 2022

@Dipet sorry for the late update. Please do let me know if there are any problems being faced while running or reviewing the eraser module.

@Lemorra
Copy link
Author

Lemorra commented Sep 3, 2022

@Dipet, I request you to explain the label "wontfix". Does this mean that this feature is of no help to albumentations repo and won't be merged to the master?

@Dipet
Copy link
Collaborator

Dipet commented Sep 3, 2022

Hi. sorry that I did not write explanation.
Need to remove sampleImages directory. We decided do not store any binary data inside this repository. For examples and documentation we hav this repository https://github.com/albumentations-team/albumentations_examples4
The current implementaion does not inherit from ImageOnlyTransform or DuatlTransorm and can not work inside Compose. For these reason we can not now aprove this PR.

@Lemorra
Copy link
Author

Lemorra commented Oct 13, 2022

@Dipet , sorry for the late update. I have tried using the image only transform class for creating a new class named "MetaData" for the eraser feature. I have implemented some methods to it. Do review it and let me know if those methods are correct or not. Also I will be removing those images in my next commit once I get a reply from you regarding the methods of the new class.

@Lemorra
Copy link
Author

Lemorra commented Nov 9, 2022

@Dipet, do review my implementation of the feature that can be run with Compose. Your inputs will help me progress in getting the feature implemented in albumentations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch conflict Improvements needed Something not implemented well. The maintainers requested improvements. wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants