Ref/refactor sorting tests #54
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following PR, the proposed changes are
Changes to the Sorting classes
items
kwarg was moved from the sorting class constructor to the sort method. This way, the constructor is used as a configurator (construction) and the same instance of the sorting class can be used for ordering multiple listsTest implementation
Changes related to the preivous tests
comp_func
. It would be better that the tests are agnostic to this function. SO testing with simple numbers could be enough.