Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #217

Merged
merged 2 commits into from
Nov 23, 2024

Update SHELL_CONFIG env variable creation in docs

8f1596f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Update docs #217

Update SHELL_CONFIG env variable creation in docs
8f1596f
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Nov 23, 2024 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 91 in trustchain-http/src/verifier.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> trustchain-http/src/verifier.rs:88:1
   |
88 | / pub enum PresentationOrCredential {
89 | |     Presentation(Presentation),
   | |     -------------------------- the largest variant contains at least 1592 bytes
90 | |     Credential(Credential),
   | |     ---------------------- the second-largest variant contains at least 1064 bytes
91 | | }
   | |_^ the entire enum is at least 1592 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
89 |     Presentation(Box<Presentation>),
   |                  ~~~~~~~~~~~~~~~~~

Check warning on line 214 in trustchain-http/src/attestation_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&PathBuf` instead of `&Path` involves a new object where a slice will do

warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
   --> trustchain-http/src/attestation_utils.rs:214:44
    |
214 |     fn elementwise_deserialize(self, path: &PathBuf) -> Result<Option<Self>, TrustchainCRError>
    |                                            ^^^^^^^^ help: change this to: `&Path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

Check warning on line 200 in trustchain-http/src/attestation_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&PathBuf` instead of `&Path` involves a new object where a slice will do

warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
   --> trustchain-http/src/attestation_utils.rs:200:43
    |
200 |     fn elementwise_serialize(&self, path: &PathBuf) -> Result<(), TrustchainCRError> {
    |                                           ^^^^^^^^ help: change this to: `&Path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
    = note: `#[warn(clippy::ptr_arg)]` on by default