Skip to content

Remove unused deps, autoinherit and restructure #525

Remove unused deps, autoinherit and restructure

Remove unused deps, autoinherit and restructure #525

Triggered via pull request January 13, 2025 16:58
Status Success
Total duration 2m 45s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
rustfmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
large size difference between variants: crates/trustchain-http/src/verifier.rs#L88
warning: large size difference between variants --> crates/trustchain-http/src/verifier.rs:88:1 | 88 | / pub enum PresentationOrCredential { 89 | | Presentation(Presentation), | | -------------------------- the largest variant contains at least 1592 bytes 90 | | Credential(Credential), | | ---------------------- the second-largest variant contains at least 1064 bytes 91 | | } | |_^ the entire enum is at least 1592 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 89 | Presentation(Box<Presentation>), | ~~~~~~~~~~~~~~~~~
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do: crates/trustchain-http/src/attestation_utils.rs#L214
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do --> crates/trustchain-http/src/attestation_utils.rs:214:44 | 214 | fn elementwise_deserialize(self, path: &PathBuf) -> Result<Option<Self>, TrustchainCRError> | ^^^^^^^^ help: change this to: `&Path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do: crates/trustchain-http/src/attestation_utils.rs#L200
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do --> crates/trustchain-http/src/attestation_utils.rs:200:43 | 200 | fn elementwise_serialize(&self, path: &PathBuf) -> Result<(), TrustchainCRError> { | ^^^^^^^^ help: change this to: `&Path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
unneeded `return` statement: crates/trustchain-core/src/utils.rs#L275
warning: unneeded `return` statement --> crates/trustchain-core/src/utils.rs:275:41 | 275 | / ... return json_contains( 276 | | ... cand_map.get(cand_key).unwrap(), 277 | | ... expected, 278 | | ... ) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 275 ~ json_contains( 276 + cand_map.get(cand_key).unwrap(), 277 + expected, 278 + ) |
unneeded `return` statement: crates/trustchain-core/src/utils.rs#L296
warning: unneeded `return` statement --> crates/trustchain-core/src/utils.rs:296:21 | 296 | / return cand_map 297 | | .values() 298 | | .any(|cand_value| json_contains(cand_value, expected)); | |______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 296 ~ cand_map 297 + .values() 298 ~ .any(|cand_value| json_contains(cand_value, expected)) |
unneeded `return` statement: crates/trustchain-core/src/utils.rs#L261
warning: unneeded `return` statement --> crates/trustchain-core/src/utils.rs:261:13 | 261 | return cand_vec.iter().any(|value| json_contains(value, expected)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 261 - return cand_vec.iter().any(|value| json_contains(value, expected)); 261 + cand_vec.iter().any(|value| json_contains(value, expected)) |
Docs
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
clippy_check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636