Skip to content

Remove unused deps, autoinherit and restructure #521

Remove unused deps, autoinherit and restructure

Remove unused deps, autoinherit and restructure #521

Triggered via pull request November 27, 2024 13:35
Status Success
Total duration 2m 45s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 warnings
large size difference between variants: crates/trustchain-http/src/verifier.rs#L88
warning: large size difference between variants --> crates/trustchain-http/src/verifier.rs:88:1 | 88 | / pub enum PresentationOrCredential { 89 | | Presentation(Presentation), | | -------------------------- the largest variant contains at least 1592 bytes 90 | | Credential(Credential), | | ---------------------- the second-largest variant contains at least 1064 bytes 91 | | } | |_^ the entire enum is at least 1592 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 89 | Presentation(Box<Presentation>), | ~~~~~~~~~~~~~~~~~
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do: crates/trustchain-http/src/attestation_utils.rs#L214
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do --> crates/trustchain-http/src/attestation_utils.rs:214:44 | 214 | fn elementwise_deserialize(self, path: &PathBuf) -> Result<Option<Self>, TrustchainCRError> | ^^^^^^^^ help: change this to: `&Path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
writing `&PathBuf` instead of `&Path` involves a new object where a slice will do: crates/trustchain-http/src/attestation_utils.rs#L200
warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do --> crates/trustchain-http/src/attestation_utils.rs:200:43 | 200 | fn elementwise_serialize(&self, path: &PathBuf) -> Result<(), TrustchainCRError> { | ^^^^^^^^ help: change this to: `&Path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default